Customer token #12
Merged
Customer token #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elroie
requested changes
Jun 23, 2021
resources/customerToken.ts
Outdated
| } | ||
|
|
||
| // public async createToken(request: CreateTokenRequest) : Promise<UnitResponse<CustomerToken> | UnitError> { | ||
| public async createToken(request: CreateTokenRequest) { |
Contributor
There was a problem hiding this comment.
lets keep the method signature
and remove the comment
types/customerToken.ts
Outdated
| /** | ||
| * send a verification code to the customer through one of the following channels sms or call. | ||
| */ | ||
| channel: string |
Contributor
There was a problem hiding this comment.
use "sms" | "call" (verify with the docs)
Suggested change
| channel: string | |
| channel: "sms" | "call" |
types/customerToken.ts
Outdated
| * string 6 digits code sent to the customer through the desired channel. | ||
| * Required if the scope attribute includes a scope which requires two-factor authentication. | ||
| */ | ||
| verificationCode?: string} |
Contributor
There was a problem hiding this comment.
Suggested change
| verificationCode?: string} | |
| verificationCode?: string | |
| } |
Elroie
requested changes
Jun 24, 2021
types/customerToken.ts
Outdated
| } | ||
|
|
||
| export interface CreateTokenVerificationRequest { | ||
| customerId: string |
Contributor
There was a problem hiding this comment.
this is not really part of this request, its the identifier of this route so move it from the request and lets add it as a parameter to createTokenVerification
types/customerToken.ts
Outdated
| import { Phone } from "./common"; | ||
|
|
||
| export interface CreateTokenRequest { | ||
| customerId: string |
Contributor
There was a problem hiding this comment.
see me comment on:
CreateTokenVerificationRequest
resources/customerToken.ts
Outdated
| super(token,basePath + '/customers') | ||
| } | ||
|
|
||
| public async createToken(request: CreateTokenRequest) : Promise<UnitResponse<CustomerToken> | UnitError> { |
Contributor
There was a problem hiding this comment.
Suggested change
| public async createToken(request: CreateTokenRequest) : Promise<UnitResponse<CustomerToken> | UnitError> { | |
| public async createToken(customerId: string, request: CreateTokenRequest) : Promise<UnitResponse<CustomerToken> | UnitError> { |
resources/customerToken.ts
Outdated
| return this.httpPost<UnitResponse<CustomerToken>>(`/${request.customerId}/token`, { data: request.data }) | ||
| } | ||
|
|
||
| public async createTokenVerification(request: CreateTokenVerificationRequest) : Promise<UnitResponse<VerificationToken> | UnitError> { |
Contributor
There was a problem hiding this comment.
Suggested change
| public async createTokenVerification(request: CreateTokenVerificationRequest) : Promise<UnitResponse<VerificationToken> | UnitError> { | |
| public async createTokenVerification(customerId:string, request: CreateTokenVerificationRequest) : Promise<UnitResponse<VerificationToken> | UnitError> { |
Elroie
approved these changes
Jun 24, 2021
Elroie
requested changes
Jun 24, 2021
ilyamerman
pushed a commit
that referenced
this pull request
May 30, 2022
YegorZh
pushed a commit
to YegorZh/unit-node-sdk
that referenced
this pull request
Mar 21, 2024
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.